Point .mcp.json at local SpliceKit checkout - #83
Open
Sungurulol wants to merge 1 commit into
Open
Conversation
Update the splicekit MCP server command/args from the previous maintainer's paths to this machine's venv and repo location so the MCP server resolves on startup. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".mcp.json">
<violation number="1" location=".mcp.json:4">
P2: This committed config still hardcodes a machine-specific absolute path (/Users/sunguru/...), so the splicekit MCP server only resolves on this contributor's machine — the same failure the PR reports fixing for the previous contributor. Use the repo's portable form instead: command "/Users/sunguru/.venvs/splicekit-mcp/bin/python" should be the $HOME-derived path the Makefile/README standardize on, and the server.py path should be relative to the repo (e.g. ./mcp/server.py or $PWD).</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "splicekit": { | ||
| "command": "/Users/briantate/.venvs/splicekit-mcp/bin/python", | ||
| "args": ["/Users/briantate/Documents/GitHub/SpliceKit/mcp/server.py"] | ||
| "command": "/Users/sunguru/.venvs/splicekit-mcp/bin/python", |
There was a problem hiding this comment.
P2: This committed config still hardcodes a machine-specific absolute path (/Users/sunguru/...), so the splicekit MCP server only resolves on this contributor's machine — the same failure the PR reports fixing for the previous contributor. Use the repo's portable form instead: command "/Users/sunguru/.venvs/splicekit-mcp/bin/python" should be the $HOME-derived path the Makefile/README standardize on, and the server.py path should be relative to the repo (e.g. ./mcp/server.py or $PWD).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .mcp.json, line 4:
<comment>This committed config still hardcodes a machine-specific absolute path (/Users/sunguru/...), so the splicekit MCP server only resolves on this contributor's machine — the same failure the PR reports fixing for the previous contributor. Use the repo's portable form instead: command "/Users/sunguru/.venvs/splicekit-mcp/bin/python" should be the $HOME-derived path the Makefile/README standardize on, and the server.py path should be relative to the repo (e.g. ./mcp/server.py or $PWD).</comment>
<file context>
@@ -1,8 +1,8 @@
"splicekit": {
- "command": "/Users/briantate/.venvs/splicekit-mcp/bin/python",
- "args": ["/Users/briantate/Documents/GitHub/SpliceKit/mcp/server.py"]
+ "command": "/Users/sunguru/.venvs/splicekit-mcp/bin/python",
+ "args": ["/Users/sunguru/SpliceKit/mcp/server.py"]
}
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mcp.jsonhardcoded the previous contributor's (briantate) Python venv path and repo checkout path for thesplicekitMCP server, which meant the MCP server failed to resolve/start on any other machine.commandandargsto this machine's venv (/Users/sunguru/.venvs/splicekit-mcp/bin/python) and repo location (/Users/sunguru/SpliceKit/mcp/server.py).Note for reviewer
.mcp.jsonappears to store an absolute, machine-specific path rather than something portable (e.g. a relative path,$HOME-relative path, or an env var) — the same pattern was already present forbriantate's machine before this change. This PR follows that existing convention rather than introducing a new one. If a portable form is preferred going forward (so each contributor doesn't need to hand-edit this file), happy to follow up with that instead — flagging in case that's the better long-term fix.Test plan
splicekitMCP server connects andbridge_statusreturns a healthy response against a running Final Cut Pro instance after this change.Summary by cubic
Points
.mcp.jsonsplicekitMCP server to this machine’s venv and repo paths so the server starts locally. Previously it used another contributor’s absolute paths and failed to resolve; now it uses/Users/sunguru/.venvs/splicekit-mcp/bin/pythonand/Users/sunguru/SpliceKit/mcp/server.py, which is still machine-specific.Review notes
commandandargsforsplicekit; no runtime code changes.Developer action
.mcp.jsonto your local venv and repo to run thesplicekitserver on your machine.Written for commit ebd5290. Summary will update on new commits.