Skip to content

Compile quoted - #250

Merged
bryanjos merged 2 commits into
masterfrom
compile_quoted
Feb 25, 2017
Merged

Compile quoted#250
bryanjos merged 2 commits into
masterfrom
compile_quoted

Conversation

@bryanjos

Copy link
Copy Markdown
Collaborator

fixes #248
fixes #249

@bryanjos
bryanjos merged commit 334f324 into master Feb 25, 2017
@bryanjos
bryanjos deleted the compile_quoted branch February 25, 2017 02:14
@mrdziuban

Copy link
Copy Markdown
Contributor

@bryanjos Thanks for the quick turnaround on this, but I think it introduces another bug. Globally scoped JS functions (e.g. :console.log) now throw the error:

** (UndefinedFunctionError) function :console.log/1 is undefined (module :console is not available)
    :console.log("test")
    nofile:1: (module)
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6

@bryanjos

Copy link
Copy Markdown
Collaborator Author

That's actually more correct, but I just backed out the changes to compile_quoted. Especially since it didn't fix the original bug. in #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure code going through ElixirScript.compile and ElixirScript.compile_quoted goes through Elixir Compiler Enum.member? not translated correctly

2 participants