Deprecation changes and use of @impl in Plug Lesson#3074
Merged
erickgnavar merged 3 commits intoelixirschool:mainfrom Jan 30, 2026
Merged
Deprecation changes and use of @impl in Plug Lesson#3074erickgnavar merged 3 commits intoelixirschool:mainfrom
erickgnavar merged 3 commits intoelixirschool:mainfrom
Conversation
Changes 'use Plug.Test' to 'import Plug.Test' as previous statement is deprecated. Changes 'defp handle_errors/2' to @impl Plug.ErrorHandler def handle_errors/2 per https://hexdocs.pm/plug/Plug.ErrorHandler.html
Member
|
Thank you @Jeberlen! Would you be willing to find-and-replace this change across all translations? |
Contributor
Author
Yes, I did not think about that! Will get to it asap. |
erickgnavar
approved these changes
Jan 30, 2026
Member
|
Amazing, thank you @Jeberlen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes 'use Plug.Test' to 'import Plug.Test' as previous statement is deprecated
Changed 'defp handle_errors/2' to 'def handle_errors/2' with @impl Plug.ErrorHandler per https://hexdocs.pm/plug/Plug.ErrorHandler.html