Update enum.md to introduce map before each#3036
Open
jl33-ai wants to merge 4 commits intoelixirschool:mainfrom
Open
Update enum.md to introduce map before each#3036jl33-ai wants to merge 4 commits intoelixirschool:mainfrom
map before each#3036jl33-ai wants to merge 4 commits intoelixirschool:mainfrom
Conversation
Introduce 'map' before 'each' for more easy to follow ordering.
kinson
reviewed
Jul 31, 2025
Contributor
kinson
left a comment
kinson
left a comment
There was a problem hiding this comment.
@doomspork is this worth bumping the version for?
Member
Contributor
|
@jl33-ai if it helps, here is a bit more context on lesson versioning: https://github.com/elixirschool/elixirschool/blob/main/CONTRIBUTING.md#a-note-on-lesson-versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Introduce
mapbeforeeachfor more easy to follow ordering.Why?
While this is an extreme nitpick, I did find the original ordering slightly unintuitive.
When I read "It may be necessary to iterate over a collection without producing a new value", this led me to waste a few seconds searching for the classic
mapfunction (this is what the majority of developers be familiar with).Since
eachis a less common function, I assumed that I had accidentally missed themapfunction.