Traverse "extends" properties and flatten the inherited structure. - #5
Merged
Merged
Conversation
Collaborator
|
Really sorry, will take a look at this this week. |
Collaborator
|
This seems good, is it ready to merge? |
Moosieus
marked this pull request as ready for review
December 14, 2025 20:10
Contributor
Author
|
Should be, spot-checking a few final things |
Contributor
Author
|
All looks kosher to me. Generated code follows LSP specification as far as I've spot-checked, no anomalies or issues. Also maps the expected progress token at runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent being to ensure that the
workDoneTokenproperty is properly included into the generated initializeParams struct.