Add put_peer_data to Plug.Test#745
Merged
Merged
Conversation
josevalim
reviewed
Jul 29, 2018
| case conn.adapter do | ||
| {Plug.MissingAdapter, _} -> %{address: {127, 0, 0, 1}, port: 111_317, ssl_cert: nil} | ||
| {adapter, payload} -> adapter.get_peer_data(payload) | ||
| end, |
Member
There was a problem hiding this comment.
Let's encapsulate this in a function given this and the code below do the same thing?
For example, get_from_adapter(conn, op, default) which we would call as get_from_adapter(conn, :get_peer_data, %{address: {127, 0, 0, 1}, port: 111_317, ssl_cert: nil})?
Member
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Aug 4, 2018
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Gazler
pushed a commit
to Gazler/plug
that referenced
this pull request
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no way to set the peer data in test. This PR adds
put_peer_data/2toPlug.Test