Fix DinoV2 crash when batch_size > 1 - #429
Merged
Merged
Conversation
| interpolated_position_embeddings = | ||
| input_position_embeddings | ||
| |> Nx.reshape({batch_size, original_positions, original_positions, spec.hidden_size}) | ||
| |> Nx.reshape({1, original_positions, original_positions, spec.hidden_size}) |
Member
There was a problem hiding this comment.
@zacharydenton great find! I would suggest a small improvement:
position_embeddings_batch_size = Nx.axis_size(position_embeddings, 0)and then use that in both places.
In practice it's always 1, but hardcoding the value implies an extra assumption that the reader may need to understand, which means going back to the caller side and figuring out the position embeddings shape :)
jonatanklosko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error in interpolate_position_embeddings when batch_size is > 1 (#428).