Add negative prompts - #109
Merged
Merged
Conversation
josevalim
reviewed
Dec 14, 2022
Comment on lines
+401
to
+402
| defp get_tokens(prompts) when is_list(prompts), | ||
| do: Enum.flat_map(prompts, &get_tokens/1) |
Contributor
There was a problem hiding this comment.
Should this clause be removed? I don't think they can be lists based on validate_input?
Contributor
Author
There was a problem hiding this comment.
You are right, I was looking at the implementation of validate_serving_inputs in Shared which supports lists as functions
jonatanklosko
approved these changes
Dec 14, 2022
Member
|
We are making a patch release, so I'm going to merge this too :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #105
It looks decent?