fix: use @electron-forge/cli hint for project resolution (#3023)

MarshallOfSound · web-flow · commit b5d058749418 · 2022-10-31T09:48:12.000-07:00
We were falling back to the "best guess" behavior for the forge.config.js scenario, we can do better than best guess and infer a forge project based on a forge dependency
diff --git a/packages/api/core/src/util/resolve-dir.ts b/packages/api/core/src/util/resolve-dir.ts
@@ -39,6 +39,11 @@ export default async (dir: string): Promise<string | null> => {
         return mDir;
       }
 
+      if (packageJSON.devDependencies?.['@electron-forge/cli']) {
+        d('package.json with forge dependency found in', testPath);
+        return mDir;
+      }
+
       bestGuessDir = mDir;
     }
     mDir = path.dirname(mDir);

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,11 @@ export default async (dir: string): Promise<string \| null> => {`
`39`	`39`	`return mDir;`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ if (packageJSON.devDependencies?.['@electron-forge/cli']) {`
	`43`	`+ d('package.json with forge dependency found in', testPath);`
	`44`	`+ return mDir;`
	`45`	`+ }`
	`46`	`+`
`42`	`47`	`bestGuessDir = mDir;`
`43`	`48`	`}`
`44`	`49`	`mDir = path.dirname(mDir);`