fix: allow docking DevTools with WCO - #35754
Merged
Merged
Conversation
codebytere
added
semver/patch
codebytere
changed the title
codebytere
changed the title
jkleinsc
approved these changes
Sep 21, 2022
|
Release Notes Persisted
|
This was referenced Sep 22, 2022
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #35763 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #35764 |
Contributor
|
I have automatically backported this PR to "21-x-y", please check out #35765 |
trop
Bot
added
in-flight/21-x-y
and removed
target/20-x-y
target/21-x-y
|
เป้าหมาย/21-xy หมายถึงอะไร |
trop
Bot
added
merged/21-x-y
ghost
mentioned this pull request
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: allow for docking devtools with WCO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #35715.
Refactor #35209 to default the devtools position to
detachrather than forcing it unilaterally.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where DevTools could not be docked with Windows Control Overlay enabled.