Skip to content

fix: Node.js atob input validation - #35444

Merged
codebytere merged 2 commits into
19-x-yfrom
trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812
Sep 22, 2022
Merged

fix: Node.js atob input validation#35444
codebytere merged 2 commits into
19-x-yfrom
trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812

Conversation

@trop

@trop trop Bot commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

Backport of #35415

See that PR for details.

Notes: Fixed a bug where calling atob in the renderer process could fail under some circumstances.

@trop
trop Bot requested review from a team as code owners August 25, 2022 06:55
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Aug 25, 2022
@trop
trop Bot requested a review from codebytere August 25, 2022 06:56
@trop trop Bot mentioned this pull request Aug 25, 2022
3 tasks
@trop trop Bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 25, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Aug 25, 2022
@codebytere
codebytere force-pushed the trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812 branch from cfee141 to 91a1299 Compare August 25, 2022 10:21
zcbenz
zcbenz previously requested changes Aug 29, 2022

@zcbenz zcbenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch doesn't apply.

@codebytere
codebytere dismissed zcbenz’s stale review September 22, 2022 07:54

Patch corrected

@codebytere
codebytere merged commit 7d84b3b into 19-x-y Sep 22, 2022
@codebytere
codebytere deleted the trop/19-x-y-bp-fix-node-js-atob-input-validation-1661410545812 branch September 22, 2022 07:54
@release-clerk

release-clerk Bot commented Sep 22, 2022

Copy link
Copy Markdown

Release Notes Persisted

Fixed a bug where calling atob in the renderer process could fail under some circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants