fix: undefined details.requestingUrl from session.setPermissionCheckHandler - #35281
Merged
Conversation
deepak1556
added
semver/patch
miniak
requested changes
Aug 9, 2022
miniak
left a comment
miniak
left a comment
Contributor
There was a problem hiding this comment.
I think the WebFrameMain::ExecuteJavaScript change should be a separate PR
5 tasks
deepak1556
force-pushed
the
robo/fix_permission_handler_details
branch
from
August 10, 2022 04:27
06f1491 to
a8f0c4a
Compare
miniak
approved these changes
Aug 10, 2022
deepak1556
force-pushed
the
robo/fix_permission_handler_details
branch
from
August 17, 2022 15:17
a8f0c4a to
b63dc8e
Compare
codebytere
approved these changes
Aug 22, 2022
zcbenz
approved these changes
Aug 23, 2022
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #35407 |
This was referenced Aug 23, 2022
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #35408 |
Contributor
|
I have automatically backported this PR to "21-x-y", please check out #35409 |
trop
Bot
added
merged/21-x-y
ghost
mentioned this pull request
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…andler (electron#35281) fix: undefined details.requestingUrl from setPermissionCheckHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
With 7e59d78, https://chromium-review.googlesource.com/c/chromium/src/+/3495142 deprecates
GetPermissionStatusForFramein favor ofGetPermissionStatusForCurrentDocumentand the latter always called intoGetPermissionStatuswhich does not have a frame context leading to emptyRenderFrameHostcausing the above issue.Depends on #35292
Checklist
npm testpassesRelease Notes
Notes: fix undefined details.requestingUrl from session.setPermissionCheckHandler