fix: touch events not recognized by WCO on windows - #35117
Merged
Conversation
deepak1556
marked this pull request as ready for review
July 28, 2022 15:40
deepak1556
added
18-x-y
19-x-y
20-x-y
semver/patch
MarshallOfSound
approved these changes
Jul 29, 2022
zcbenz
approved these changes
Aug 2, 2022
Member
Author
|
Failing tests are unrelated, merging. |
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "19-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "18-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #35174 |
Contributor
|
@deepak1556 has manually backported this PR to "19-x-y", please check out #35176 |
Contributor
|
@deepak1556 has manually backported this PR to "18-x-y", please check out #35177 |
jkleinsc
pushed a commit
that referenced
this pull request
Aug 2, 2022
ghost
mentioned this pull request
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
NB: We only let chromium handle the mouse event for touch when the HTTEST is in the caption button area of WCO, so it does not affect regular mouse event or other non-WCO code path. Also, the bugs referred in https://chromium-review.googlesource.com/c/chromium/src/+/1048877/ are not introduced with this change.
Fixes #34364
Release Notes
Notes: fix WCO not responding to touch events on windows.