Skip to content

fix: allow setsize to be called within a move or resize for preventDefault - #35084

Merged
codebytere merged 1 commit into
20-x-yfrom
trop/20-x-y-bp-fix-allow-setsize-to-be-called-within-a-move-or-resize-for-preventdefault-1658880152428
Jul 27, 2022
Merged

fix: allow setsize to be called within a move or resize for preventDefault#35084
codebytere merged 1 commit into
20-x-yfrom
trop/20-x-y-bp-fix-allow-setsize-to-be-called-within-a-move-or-resize-for-preventdefault-1658880152428

Conversation

@trop

@trop trop Bot commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Backport of #34843

See that PR for details.

Notes: Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jul 27, 2022
@trop trop Bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 27, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jul 27, 2022
@codebytere
codebytere merged commit 7b1872d into 20-x-y Jul 27, 2022
@codebytere
codebytere deleted the trop/20-x-y-bp-fix-allow-setsize-to-be-called-within-a-move-or-resize-for-preventdefault-1658880152428 branch July 27, 2022 09:14
@release-clerk

release-clerk Bot commented Jul 27, 2022

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants