fix: crash on startup in X11 - #35075
Merged
deepak1556 merged 1 commit intoJul 27, 2022
Merged
Conversation
VerteDinde
approved these changes
Jul 26, 2022
VerteDinde
left a comment
VerteDinde
left a comment
Member
There was a problem hiding this comment.
Nice! 🙌 Tested on Fedora with X11, crash is no longer happening
codebytere
approved these changes
Jul 26, 2022
zcbenz
approved these changes
Jul 27, 2022
deepak1556
approved these changes
Jul 27, 2022
Member
|
Failing test is unrelated, merging. |
deepak1556
deleted the
fix/34996-regression-crash-on-startup-in-Xorg-on-20.0.0-beta.9
branch
July 27, 2022 04:44
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #35092 |
ghost
mentioned this pull request
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #34996.
This is a regression introduced in 20.0.0-beta.9 caused by
ElectronBrowserMainParts::PreCreateThreads()creating the main window before loading the locale resource bundle, butui::BuildDisplaysFromXRandRInfo()needed that locale info to be loaded.CC @electron/wg-releases
Checklist
npm testpassesRelease Notes
Notes: Fix 20.0.0-beta.8 X11 crash regression.