Skip to content

fix: ensure that v8 sandbox isnt enabled for arm - #34914

Merged
codebytere merged 1 commit into
mainfrom
fix-arm-native-modules
Jul 14, 2022
Merged

fix: ensure that v8 sandbox isnt enabled for arm#34914
codebytere merged 1 commit into
mainfrom
fix-arm-native-modules

Conversation

@MarshallOfSound

Copy link
Copy Markdown
Member

Notes: Fixes native module compilation issues on arm

@MarshallOfSound
MarshallOfSound requested review from a team as code owners July 13, 2022 20:11
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jul 13, 2022
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/20-x-y fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases labels Jul 13, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jul 13, 2022
@codebytere
codebytere merged commit 9a5d759 into main Jul 14, 2022
@codebytere
codebytere deleted the fix-arm-native-modules branch July 14, 2022 08:46
@release-clerk

release-clerk Bot commented Jul 14, 2022

Copy link
Copy Markdown

Release Notes Persisted

Fixes native module compilation issues on arm

@trop

trop Bot commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

@trop

trop Bot commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

@VerteDinde has manually backported this PR to "20-x-y", please check out #35137

jkleinsc pushed a commit that referenced this pull request Jul 29, 2022
fix: ensure that v8 sandbox isnt enabled for arm (#34914)

Co-authored-by: Samuel Attard <sam@electronjs.org>
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants