fix: enable deviceName validation on Linux - #34872
Merged
Merged
Conversation
codebytere
force-pushed
the
clean-up-deviceName-validation
branch
from
July 11, 2022 09:44
affcc8e to
1b62d59
Compare
codebytere
changed the title
deviceName validation on Linux
codebytere
marked this pull request as draft
July 11, 2022 11:38
codebytere
force-pushed
the
clean-up-deviceName-validation
branch
from
July 11, 2022 11:39
1b62d59 to
f0adf5f
Compare
codebytere
marked this pull request as ready for review
July 11, 2022 11:43
deepak1556
approved these changes
Jul 11, 2022
Member
Author
|
Release Notes Persisted
|
This was referenced Jul 13, 2022
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34900 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34901 |
ghost
mentioned this pull request
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables printer validity to be verified on Linux. At the moment, if an invalid
deviceNameis passed to Linux, it will just fail silently. This makes it such that the callback is called with a failure if thedeviceNameis invalid, as well as consolidates some of the validation logic so that, among other things,IsDeviceNameValidis only called once.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where printing with an invalid
deviceNameon Linux caused silent failures.