Skip to content

fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules - #34851

Merged
VerteDinde merged 5 commits into
20-x-yfrom
trop/20-x-y-bp-fix-ensure-v8-pointer-compression-sandbox-is-enabled-on-64bit-native-modules-1657267590845
Jul 8, 2022
Merged

fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules#34851
VerteDinde merged 5 commits into
20-x-yfrom
trop/20-x-y-bp-fix-ensure-v8-pointer-compression-sandbox-is-enabled-on-64bit-native-modules-1657267590845

Conversation

@trop

@trop trop Bot commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Backport of #34844

See that PR for details.

Notes: Fixed spontaneous crashing in native modules that depended on nan

@trop
trop Bot requested review from a team as code owners July 8, 2022 08:06
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jul 8, 2022
@trop
trop Bot requested a review from MarshallOfSound July 8, 2022 08:06
@trop trop Bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 8, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jul 8, 2022
@MarshallOfSound

Copy link
Copy Markdown
Member

Currently this PR sets v8_enable_sandbox to 0 no matter what, that is because the v8 sandbox is still disabled in the 20-x-y branch. When it is enabled that flag should be flipped to 1 in this patch.

@VerteDinde

Copy link
Copy Markdown
Member

WOA is green, but GitHub hasn't updated status - merging as others are green

@VerteDinde
VerteDinde merged commit c10eece into 20-x-y Jul 8, 2022
@VerteDinde
VerteDinde deleted the trop/20-x-y-bp-fix-ensure-v8-pointer-compression-sandbox-is-enabled-on-64bit-native-modules-1657267590845 branch July 8, 2022 11:51
@release-clerk

release-clerk Bot commented Jul 8, 2022

Copy link
Copy Markdown

Release Notes Persisted

Fixed spontaneous crashing in native modules that depended on nan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants