Skip to content

fix: update Windows caption buttons to match Win11 style - #34790

Merged
codebytere merged 2 commits into
mainfrom
win-icon-painter
Jul 12, 2022
Merged

fix: update Windows caption buttons to match Win11 style#34790
codebytere merged 2 commits into
mainfrom
win-icon-painter

Conversation

@codebytere

@codebytere codebytere commented Jun 29, 2022

Copy link
Copy Markdown
Member

Description of Change

Refs CL:3674580

This PR updates WCO restore and maximize buttons to match Windows 11 design. It also refactors out the functionality into its own file, as the above CL does, to make it more maintainable an extensible

Checklist

Release Notes

Notes: Updated Windows Control Overlay buttons to look and feel more native on Windows 11.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/20-x-y labels Jun 29, 2022
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 29, 2022
@codebytere
codebytere force-pushed the win-icon-painter branch 2 times, most recently from 8def0c3 to d782824 Compare June 29, 2022 16:12
Comment thread shell/browser/ui/views/win_icon_painter.cc Outdated
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 30, 2022
@codebytere
codebytere requested review from clavin and jkleinsc July 7, 2022 09:33
@codebytere

Copy link
Copy Markdown
Member Author

@clavin issues should be resolved!

@codebytere
codebytere requested a review from zcbenz July 11, 2022 10:02
@codebytere
codebytere merged commit 95019f0 into main Jul 12, 2022
@codebytere
codebytere deleted the win-icon-painter branch July 12, 2022 07:13
@release-clerk

release-clerk Bot commented Jul 12, 2022

Copy link
Copy Markdown

Release Notes Persisted

Updated Windows Control Overlay buttons to look and feel more native on Windows 11.

@trop

trop Bot commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "20-x-y", please check out #34888

@trop

trop Bot commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

@rzhao271 has manually backported this PR to "19-x-y", please check out #35314

rzhao271 pushed a commit to rzhao271/electron that referenced this pull request Aug 12, 2022
devinfoley pushed a commit to devinfoley/electron that referenced this pull request Aug 16, 2022
fix: update Windows caption buttons to match Win11 style (electron#34790)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants