fix: crash when setWindowOpenHandler callback throws - #34772
Merged
Conversation
4 tasks
trop
Bot
added
17-x-y
backport
miniak
force-pushed
the
miniak/fix-handler-throw-17-x-y
branch
from
June 28, 2022 16:51
24d368f to
8e8a871
Compare
codebytere
approved these changes
Jun 29, 2022
VerteDinde
approved these changes
Jun 29, 2022
Member
|
win-x64 is green, just not reporting as such on the GitHub GUI. |
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34523
See that PR for details.
Notes: Fixed an error where
setWindowOpenHandler()would crash if the callback threw an error