fix: WCO pressed background state updates - #34771
Merged
Merged
Conversation
codebytere
force-pushed
the
wco-background-button-painting
branch
from
June 28, 2022 13:57
4981b20 to
cfee973
Compare
mlaurencin
approved these changes
Jun 28, 2022
codebytere
force-pushed
the
wco-background-button-painting
branch
from
June 29, 2022 11:18
53d5a90 to
6e94112
Compare
Member
Author
|
Looks like a valid test failure - i'm looking into it! |
codebytere
force-pushed
the
wco-background-button-painting
branch
from
July 7, 2022 07:45
6e94112 to
a9d4023
Compare
Member
Author
|
@clavin @mlaurencin tests fixed! |
clavin
approved these changes
Jul 7, 2022
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "17-x-y", please check out #34837 |
This was referenced Jul 7, 2022
Contributor
|
I have automatically backported this PR to "18-x-y", please check out #34838 |
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34839 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34840 |
3 tasks
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34763.
When a window with WCO is restored after the minimize button is clicked, the button was left in the
STATE_HOVEREDstate. This meant that when the user restored (unminimized) the window, the button was incorrectly left painted as though the user was still hovered over it, and could only fix this by once again hovering over the button and then moving off of it. This issue is fixed by ensuring that windows controls are reset when the window is restored, since the buttons could neither be pressed or hovered over as that is occurring by the nature of the event taking place.Tested by adding:
to the BrowserWindow ctor options of the default Fiddle.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the minimize button with WCO enabled would incorrectly be highlighted in some cases.