fix: <datalist> bounds vertical cutoff - #34759
Merged
Merged
Conversation
codebytere
changed the title
codebytere
changed the title
<datalist> bounds vertical cutoff
deepak1556
approved these changes
Jun 27, 2022
deermichel
approved these changes
Jun 28, 2022
deermichel
left a comment
deermichel
left a comment
Contributor
There was a problem hiding this comment.
+1 for the branch name 😆
Member
Author
|
Unrelated Node.js failure on Linux. |
|
Release Notes Persisted
|
This was referenced Jun 29, 2022
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34785 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34786 |
ghost
mentioned this pull request
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34750.
Refs CL:3560843
Fixes an issue where DataList bounds had part of the item text cut off vertically. This happened in #33556 when we switched from the mult-parameter form of
gfx::Insets, since the horizontal and vertical parameters switched and we didn't catch it.Tested with https://gist.github.com/1525a4d39d33bc46eb033af6ebcf51c1.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where DataList bounds had part of the item text cut off vertically.