fix: performance problem in crashReporter.start() on macOS - #34637
Merged
zcbenz merged 5 commits intoJun 20, 2022
Merged
Conversation
This change reduces the duration of crashReporter.start() on Intel macOS from 622 milliseconds to 257 milliseconds! Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386 posix: Replace DoubleForkAndExec() with ForkAndSpawn() The DoubleForkAndExec() function was taking over 622 milliseconds to run on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding some custom traces and found that the fork() syscall is the bottleneck here, i.e., the first fork() takes around 359 milliseconds and the nested fork() takes around 263 milliseconds. Replacing the nested fork() and exec() with posix_spawn() reduces the time consumption to 257 milliseconds! See libuv/libuv#3064 to know why fork() is so slow on macOS and why posix_spawn() is a better replacement. Another point to note is that even base::LaunchProcess() from Chromium calls posix_spawnp() on macOS - https://source.chromium.org/chromium/chromium/src/+/8f8d82dea0fa8f11f57c74dbb65126f8daba58f7:base/process/launch_mac.cc;l=295-296 Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Fixes: #34321 Signed-off-by: Darshan Sen <raisinten@gmail.com>
3 tasks
codebytere
requested changes
Jun 20, 2022
codebytere
left a comment
Member
There was a problem hiding this comment.
Build failure - bad macros. They'll need updating.
codebytere
approved these changes
Jun 20, 2022
codebytere
left a comment
Member
There was a problem hiding this comment.
........nevermind, got fixed the literal moment i reviewed it.
zcbenz
approved these changes
Jun 20, 2022
zcbenz
deleted the
trop/17-x-y-bp-fix-performance-problem-in-crashreporter-start-on-macos-1655699550456
branch
June 20, 2022 10:39
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #34609
See that PR for details.
Notes: Fixes a performance problem in
crashReporter.start()on macOS.