fix: draggable regions updating on bounds change - #34582
Merged
Merged
Conversation
codebytere
requested review from
MarshallOfSound,
VerteDinde,
jkleinsc and
zcbenz
June 15, 2022 18:41
zcbenz
reviewed
Jun 16, 2022
codebytere
force-pushed
the
draggable-regions-move-windows
branch
from
June 16, 2022 10:25
c23201d to
f01c720
Compare
zcbenz
approved these changes
Jun 16, 2022
|
Release Notes Persisted
|
This was referenced Jun 17, 2022
Contributor
|
I have automatically backported this PR to "18-x-y", please check out #34610 |
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34611 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34612 |
ghost
mentioned this pull request
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34552.
Fixes an issue where draggable regions were not recalculated when BrowserView bounds changed. This was happening because we didn't issue a call to
UpdateDraggableRegionsafter bounds changed on Windows, as we do on macOS:electron/shell/browser/native_browser_view_mac.mm
Line 270 in abf6f1c
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where draggable regions were not recalculated when BrowserView bounds changed on Windows.