Skip to content

feat: add immersive dark mode on windows - #34549

Merged
zcbenz merged 1 commit into
20-x-yfrom
trop/20-x-y-bp-feat-add-immersive-dark-mode-on-windows-1655224067819
Jun 20, 2022
Merged

feat: add immersive dark mode on windows#34549
zcbenz merged 1 commit into
20-x-yfrom
trop/20-x-y-bp-feat-add-immersive-dark-mode-on-windows-1655224067819

Conversation

@trop

@trop trop Bot commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Backport of #33624

See that PR for details.

Notes: Added immersive dark mode on Windows.

* feat: add immersive dark mode

* fix syntax and add header

* add me

* Update fuses.json5

* fix: redraw title bar on dark mode change

* chore: SetWindowTheme doesn't seem to be needed

* chore: separate out Win 10 dark mode implementation

* final touches

* final touches

* chore: limit Win 10 to >= 20H1 and drop fuse

* fix types

* fix lint

Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 14, 2022
@trop
trop Bot requested a review from mlaurencin June 14, 2022 16:28
@trop trop Bot mentioned this pull request Jun 14, 2022
4 tasks
@trop trop Bot added 20-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jun 14, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 14, 2022

@zcbenz zcbenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport has been asynchronously approved by wg-releases.

@zcbenz
zcbenz merged commit 5b583c8 into 20-x-y Jun 20, 2022
@zcbenz
zcbenz deleted the trop/20-x-y-bp-feat-add-immersive-dark-mode-on-windows-1655224067819 branch June 20, 2022 04:33
@release-clerk

release-clerk Bot commented Jun 20, 2022

Copy link
Copy Markdown

Release Notes Persisted

Added immersive dark mode on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

20-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants