fix: all files selection logic on linux - #34496
Merged
Merged
Conversation
codebytere
force-pushed
the
fix-all-files-filter-linux
branch
from
June 10, 2022 08:38
99b86a0 to
1d03cf6
Compare
VerteDinde
approved these changes
Jun 10, 2022
zcbenz
approved these changes
Jun 13, 2022
|
Release Notes Persisted
|
This was referenced Jun 13, 2022
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34516 |
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34517 |
Contributor
|
I have automatically backported this PR to "18-x-y", please check out #34518 |
ghost
mentioned this pull request
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34492.
Fixes an issue where passing
{ name: 'All Files', extensions: ['*'] }in thefiltersparam of open or save dialogs on linux would disallow choosing files without an extension. This was happening because we were modifying all filters passed in to prefix them with*.:electron/shell/browser/ui/file_dialog_gtk.cc
Line 39 in 99b86a0
meaning that the All Files extension would turn into
*.*. This meaningfully changed behavior, because*in isolation allows a user to choose any file but*.*allows a user to choose any file with any extension but the extension must exist. This corrects that behavior.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where passing
{ name: 'All Files', extensions: ['*'] }in thefiltersparam of open or save dialogs on Linux would disallow choosing files without an extension.