Skip to content

fix: fullscreen windows aren't resizable on macOS - #34379

Merged
codebytere merged 3 commits into
mainfrom
fix-resizable
Jun 3, 2022
Merged

fix: fullscreen windows aren't resizable on macOS#34379
codebytere merged 3 commits into
mainfrom
fix-resizable

Conversation

@codebytere

@codebytere codebytere commented May 30, 2022

Copy link
Copy Markdown
Member

Description of Change

On macOS, BrowserWindows cannot be resized when in a fullscreen transition or when actively in fullscreen.

Checklist

Release Notes

Notes: Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels May 30, 2022
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 30, 2022
@zcbenz

zcbenz commented May 30, 2022

Copy link
Copy Markdown
Contributor

When an unresizable window enters fullscreen, it will keep its original size under fullscreen, which looks quite weird. So we made it resizable before entering fullscreen to have it be able to take all the space.
#8166

@codebytere

codebytere commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@zcbenz in that case - let's set the window mask correctly, but update the getter to properly reflect the intended result? Just pushed a commit to illustrate what i mean.

@zcbenz

zcbenz commented May 30, 2022

Copy link
Copy Markdown
Contributor

let's set the window mask correctly, but update the getter to properly reflect the intended result?

Yeah this approach should work.

@codebytere
codebytere force-pushed the fix-resizable branch 3 times, most recently from e9fd621 to 45f2584 Compare May 30, 2022 21:01
zcbenz
zcbenz approved these changes May 31, 2022
View reviewed changes
Comment thread shell/browser/native_window_mac.h Outdated
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label May 31, 2022
@codebytere
codebytere merged commit 6038e42 into main Jun 3, 2022
@codebytere
codebytere deleted the fix-resizable branch June 3, 2022 07:47
@release-clerk

release-clerk Bot commented Jun 3, 2022

Copy link
Copy Markdown

Release Notes Persisted

Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable.

@trop

trop Bot commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop

trop Bot commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot removed the target/19-x-y label Jun 3, 2022
@trop trop Bot mentioned this pull request Jun 3, 2022
Merged
@trop

trop Bot commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "20-x-y", please check out #34433

@codebytere codebytere mentioned this pull request Jul 13, 2022
Merged
@trop

trop Bot commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

@codebytere has manually backported this PR to "19-x-y", please check out #34906

@codebytere codebytere mentioned this pull request Jul 13, 2022
Merged
@trop

trop Bot commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

@codebytere has manually backported this PR to "18-x-y", please check out #34907

@ghost ghost mentioned this pull request Aug 4, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: fullscreen windows aren't resizable on macOS (electron#34379)
804804d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nornagon nornagon Awaiting requested review from nornagon
@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound
1 more reviewer
@zcbenz zcbenz zcbenz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @zcbenz