fix: zombie windows when fullscreening and closing - #34378
Merged
Conversation
codebytere
force-pushed
the
zombie-window-fix
branch
3 times, most recently
from
May 30, 2022 07:52
82056a2 to
efc897d
Compare
3 tasks
codebytere
force-pushed
the
zombie-window-fix
branch
from
May 30, 2022 09:05
efc897d to
e8863bb
Compare
codebytere
force-pushed
the
zombie-window-fix
branch
from
May 30, 2022 09:07
e8863bb to
ddcddd7
Compare
zcbenz
approved these changes
May 31, 2022
|
Release Notes Persisted
|
This was referenced May 31, 2022
Contributor
|
I have automatically backported this PR to "17-x-y", please check out #34390 |
Contributor
|
I have automatically backported this PR to "19-x-y", please check out #34391 |
Contributor
|
I have automatically backported this PR to "18-x-y", please check out #34392 |
Contributor
|
I have automatically backported this PR to "20-x-y", please check out #34393 |
ghost
mentioned this pull request
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed an issue where zombie windows can be created if
window.close()is called during a fullscreen transition. We handle this by deferring the close until the transition is complete. This also helpswebViewtest flakiness, because we can now close the window and ensure the fullscreen transition is complete.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where zombie windows can be created if
window.close()is called during a fullscreen transition.