Skip to content

refactor: only create webContents after 'will-attach-webview' - #32941

Merged
codebytere merged 1 commit into
mainfrom
miniak/refactor-webview
Jul 21, 2022
Merged

refactor: only create webContents after 'will-attach-webview'#32941
codebytere merged 1 commit into
mainfrom
miniak/refactor-webview

Conversation

@miniak

@miniak miniak commented Feb 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of Change

Merge createGuest and attachGuest handlers. Remove WebContentsPreferences::Merge.
Re-land #30311. I cannot reproduce #31689 with this change.

Checklist

Release Notes

Notes: WebContents for <webview> are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

@miniak miniak added the wip ⚒ label Feb 17, 2022
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Feb 17, 2022
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Feb 24, 2022
@miniak
miniak force-pushed the miniak/refactor-webview branch from f072da6 to 7d7c1e8 Compare May 29, 2022 16:22
@miniak
miniak marked this pull request as ready for review May 29, 2022 16:37
@miniak
miniak requested a review from a team as a code owner May 29, 2022 16:37
@miniak miniak removed the wip ⚒ label May 29, 2022
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label May 29, 2022
@miniak

miniak commented May 29, 2022

Copy link
Copy Markdown
Contributor Author

@Kilian, @ckerr please review

@miniak miniak self-assigned this May 30, 2022
@miniak miniak added semver/patch backwards-compatible bug fixes target/20-x-y labels May 30, 2022
@zcbenz
zcbenz force-pushed the miniak/refactor-webview branch from 7d7c1e8 to d9f6aee Compare June 23, 2022 01:05
@codebytere
codebytere merged commit d4e9748 into main Jul 21, 2022
@codebytere
codebytere deleted the miniak/refactor-webview branch July 21, 2022 09:29
@release-clerk

release-clerk Bot commented Jul 21, 2022

Copy link
Copy Markdown

Release Notes Persisted

WebContents for &lt;webview&gt; are now only created after the 'will-attach-webview' event is emitted and preventDefault is not called.

@trop trop Bot mentioned this pull request Jul 21, 2022
Merged
@trop

trop Bot commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "20-x-y", please check out #35016

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jul 21, 2022
@ghost ghost mentioned this pull request Sep 26, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@miniak @schetle
refactor: only create webContents after 'will-attach-webview' (electr…
94a86fe 
…on#32941)
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
refactor: only create webContents after 'will-attach-webview' (electr…
7c8aa5f 
…on#32941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@zcbenz zcbenz zcbenz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@miniak miniak

Labels

semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miniak @zcbenz @codebytere