refactor: only create webContents after 'will-attach-webview' - #30311
Merged
Conversation
miniak
changed the title
2 tasks
miniak
force-pushed
the
miniak/refactor-webview
branch
from
July 28, 2021 22:41
857d306 to
6e690a8
Compare
nornagon
approved these changes
Jul 28, 2021
nornagon
left a comment
nornagon
left a comment
Contributor
There was a problem hiding this comment.
looks like a nice refactor! as a sanity check, as i'm not sure we have any tests for it, do things still work if you detach a webview from the dom, modify its parameters, and reattach it?
ckerr
approved these changes
Aug 2, 2021
ckerr
left a comment
ckerr
left a comment
Member
There was a problem hiding this comment.
➕ on the test question; but otherwise, this looks like a good patch
miniak
force-pushed
the
miniak/refactor-webview
branch
from
August 2, 2021 15:54
6e690a8 to
1d3e538
Compare
miniak
marked this pull request as ready for review
August 2, 2021 15:55
Contributor
Author
|
@nornagon It does work. btw |
Contributor
Author
|
@zcbenz and @deepak1556 can you please review? |
deepak1556
approved these changes
Aug 2, 2021
zcbenz
approved these changes
Aug 3, 2021
|
Release Notes Persisted
|
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Closed
3 tasks
jkleinsc
pushed a commit
that referenced
this pull request
Nov 11, 2021
ckerr
added a commit
that referenced
this pull request
Nov 15, 2021
VerteDinde
pushed a commit
that referenced
this pull request
Nov 15, 2021
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
…electron#30311)" (electron#31785) This reverts commit 6e43b0b.
miniak
added a commit
that referenced
this pull request
Feb 17, 2022
miniak
added a commit
that referenced
this pull request
May 29, 2022
4 tasks
zcbenz
pushed a commit
that referenced
this pull request
Jun 23, 2022
codebytere
pushed a commit
that referenced
this pull request
Jul 25, 2022
refactor: only create webContents after 'will-attach-webview' (#30311) Co-authored-by: Milan Burda <milan.burda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Merge
createGuestandattachGuesthandlers. RemoveWebContentsPreferences::Merge.Depends on #24344 and #30280.
Checklist
npm testpassesRelease Notes
Notes: WebContents for
<webview>are now only created after the'will-attach-webview'event is emitted andpreventDefaultis not called.