Skip to content

Commit f418a49

Browse files
authored
chore: warn when using the deprecated new-window event (#34528)
1 parent bad8d5e commit f418a49

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

lib/browser/guest-window-manager.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* out-of-process (cross-origin) are created here. "Embedder" roughly means
66
* "parent."
77
*/
8-
import { BrowserWindow } from 'electron/main';
8+
import { BrowserWindow, deprecate } from 'electron/main';
99
import type { BrowserWindowConstructorOptions, Referrer, WebContents, LoadURLOptions } from 'electron/main';
1010
import { parseFeatures } from '@electron/internal/browser/parse-features-string';
1111

@@ -155,6 +155,10 @@ function emitDeprecatedNewWindowEvent ({ event, embedder, guest, windowOpenArgs,
155155
...parseContentTypeFormat(postData)
156156
} : null;
157157

158+
if (embedder.listenerCount('new-window') > 0) {
159+
deprecate.log('The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead.');
160+
}
161+
158162
embedder.emit(
159163
'new-window',
160164
event,

0 commit comments

Comments
 (0)