Deprecate allow_no_jobs and allow_no_datafeeds in favor of allow_no_match #60601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
allow_no_match
branch
from
3c68b7e to
37983fa
Compare
przemekwitek
changed the title
przemekwitek
force-pushed
the
allow_no_match
branch
from
37983fa to
c3bd05b
Compare
Author
|
run elasticsearch-ci/bwc |
przemekwitek
added
:ml
Collaborator
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
changed the title
benwtrent
reviewed
Aug 4, 2020
x-pack/plugin/src/test/resources/rest-api-spec/api/ml.stop_datafeed.json
Outdated
Show resolved
Hide resolved
...in/ml/src/main/java/org/elasticsearch/xpack/ml/rest/results/RestGetOverallBucketsAction.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Aug 4, 2020
added 4 commits
August 5, 2020 11:42
przemekwitek
force-pushed
the
allow_no_match
branch
from
441ca38 to
08aea5a
Compare
przemekwitek
pushed a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Aug 5, 2020
przemekwitek
pushed a commit
that referenced
this pull request
Aug 5, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
allow_no_jobsandallow_no_datafeedsAPI parameters in favor ofallow_no_match.The old parameters are still accepted by the APIs but the deprecation warning is emitted if the old parameter name is used in the request body or as a request param.
High-level REST client classes will now send the new
allow_no_matchparameter to the backend.Closes #60642