Adding Hit counts and Miss counts for QueryCache exposed through REST api. This resolves:#48645 #60114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raj-Datta-Manohar
force-pushed
the
master
branch
from
96dfd45 to
634426d
Compare
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/CAT APIs) |
elasticmachine
added
the
Team:Data Management
Raj-Datta-Manohar
force-pushed
the
master
branch
2 times, most recently
from
2176f15 to
33ceab7
Compare
danhermann
reviewed
Jul 28, 2020
Contributor
danhermann
left a comment
danhermann
left a comment
There was a problem hiding this comment.
@Raj-Datta-Manohar, thank you for this contribution. It looks pretty good and I think we'll be able to get it merged in. I left one minor comment below about line lengths.
server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java
Outdated
Show resolved
Hide resolved
Raj-Datta-Manohar
force-pushed
the
master
branch
from
33ceab7 to
7ae5a8e
Compare
Contributor
|
@elasticmachine ok to test |
Contributor
|
@elasticmachine update branch |
Contributor
|
Thanks, @Raj-Datta-Manohar! This looks good now and I'll get it merged. |
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 11, 2020
danhermann
added a commit
that referenced
this pull request
Aug 12, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48645