Skip to content

Fix ingest pipeline _simulate api with empty docs never returns a res… #52937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danhermann merged 5 commits into from
Mar 11, 2020
Merged

Fix ingest pipeline _simulate api with empty docs never returns a res… #52937

danhermann merged 5 commits into from
Mar 11, 2020

Conversation

@gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Feb 28, 2020

This PR relates to #52833.

The main changes are:

  1. Return 400 status code with error message if the docs array is empty.
  2. Return 400 status code with error message if the element in docs array is not a map.
  3. Check whether the docs array is empty again when executing the pipeline simulate, avoiding no response.
  4. Add some test code for the changes.

@markharwood markharwood added the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Feb 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 28, 2020

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@danhermann danhermann self-requested a review February 28, 2020 15:19
@danhermann
Copy link
Contributor

danhermann commented Mar 2, 2020

@elasticmachine update branch

danhermann
danhermann suggested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaobinlong, thank you for fixing this bug. I made a couple minor suggestions for the error messages. Otherwise, this looks great and I'll get it merged in.

@danhermann danhermann added the >bug label Mar 2, 2020
@gaobinlong
Copy link
Contributor Author

gaobinlong commented Mar 5, 2020

Thanks @danhermann and @martijnvg, I have made a new commit which contains some changes following your comment. Can you have a look on that?

@danhermann
Copy link
Contributor

danhermann commented Mar 11, 2020

@elasticmachine update branch

@danhermann
Copy link
Contributor

danhermann commented Mar 11, 2020

@elasticmachine ok to test

@danhermann
Copy link
Contributor

danhermann commented Mar 11, 2020

Thanks for the fix, @gaobinlong! I'll get this merged now.

@danhermann danhermann merged commit 7ba94d8 into elastic:master Mar 11, 2020
@danhermann danhermann mentioned this pull request Mar 11, 2020
Closed
danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request Mar 11, 2020
@gaobinlong @danhermann
Fix ingest pipeline _simulate api with empty docs never returns a res… (
2cb6209 
elastic#52937)
@danhermann danhermann mentioned this pull request Mar 11, 2020
Merged
danhermann added a commit that referenced this pull request Mar 11, 2020
@danhermann
Fix ingest pipeline _simulate api with empty docs never returns a res… (
3c954b5 
#52937) (#53436)
danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request Mar 13, 2020
@gaobinlong @danhermann
Fix ingest pipeline _simulate api with empty docs never returns a res… (
2a93f56 
elastic#52937)
@danhermann danhermann mentioned this pull request Mar 13, 2020
Merged
danhermann added a commit that referenced this pull request Mar 13, 2020
@danhermann
Fix ingest pipeline _simulate api with empty docs never returns a res… (
fb29c2d 
#52937) (#53547)
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg left review comments

+1 more reviewer

@danhermann danhermann danhermann requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.6.2 v7.7.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gaobinlong @elasticmachine @danhermann @martijnvg @markharwood @jakelandis