Skip to content

Updated implementation to keep it compatible with the latest ECS logging spec #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergeyKleyman merged 4 commits into from
Feb 8, 2021
Merged

Updated implementation to keep it compatible with the latest ECS logging spec #17

SergeyKleyman merged 4 commits into from
Feb 8, 2021

Conversation

@SergeyKleyman
Copy link
Contributor

@SergeyKleyman SergeyKleyman commented Feb 7, 2021

  • Moved ElasticCommonSchemaFormatter from Elastic\Monolog\v2\Formatter back to Elastic\Monolog\Formatter
    • To keep backward compatible with already released elastic/ecs-logging 1.0.1
    • For more seamless future support of both Monolog v1 and v2
  • To make output compatible with the latest ECS logging spec
    • Extracted log.level from log
    • Reordered fields
    • Added ecs.version

@SergeyKleyman SergeyKleyman added the enhancement New feature or request label Feb 7, 2021
@SergeyKleyman SergeyKleyman requested a review from philkra February 7, 2021 17:05
@ghost
Copy link

ghost commented Feb 7, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #17 updated

    • Start Time: 2021-02-08T07:24:37.359+0000

  • Duration: 6 min 50 sec

  • Commit: 79008ef

Test stats 🧪

Test Results
Failed 0
Passed 62
Skipped 4
Total 66

philkra
philkra approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKleyman SergeyKleyman merged commit 8ce5b79 into elastic:master Feb 8, 2021
@SergeyKleyman SergeyKleyman deleted the Fix_schema_incompat branch February 8, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@philkra philkra philkra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergeyKleyman @philkra