fix pod ID for kubernetes when using the systemd cgroup driver#631
Merged
beniwohli merged 1 commit intoelastic:masterfrom Nov 13, 2019
Merged
fix pod ID for kubernetes when using the systemd cgroup driver#631beniwohli merged 1 commit intoelastic:masterfrom
beniwohli merged 1 commit intoelastic:masterfrom
Conversation
beniwohli
changed the title
axw
reviewed
Nov 13, 2019
Member
axw
left a comment
axw
left a comment
There was a problem hiding this comment.
Looks good, and it's may be over-paranoid, but we should be conservative with the replacement.
When the systemd cgroup driver is used, cgroup paths will have hyphens (e.g. in pod UIDs) escaped to underscores. When we're parsing cgroups, we must therefore unescape them. refs elastic/apm#165
beniwohli
force-pushed
the
k8s-fix-pod-id
branch
from
1a61066 to
a8b1bdd
Compare
eyalkoren
approved these changes
Nov 13, 2019
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Nov 13, 2019
…ic#631) When the systemd cgroup driver is used, cgroup paths will have hyphens (e.g. in pod UIDs) escaped to underscores. When we're parsing cgroups, we must therefore unescape them. refs elastic/apm#165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the systemd cgroup driver is used, cgroup paths will have hyphens (e.g. in pod UIDs) escaped to underscores. When we're parsing cgroups, we must therefore unescape them.
refs elastic/apm#165