added support for chained exceptions#596
Merged
beniwohli merged 9 commits intoelastic:masterfrom Sep 27, 2019
Merged
Conversation
If an exception has a `__context__` set, we use its traceback for the chained exception. The exception type and value are either taken from `__cause__` (if set) or `__context__`. closes elastic#526
this only became apparent after reorganizing tests a bit, which moved some of the messy tests above a test that depended on a clean execution context.
Contributor
|
Ref elastic/apm#40 |
Contributor
Author
|
hmm, turns out we can't use |
also, wrap `cause` in a list as required by the APM Server API
Contributor
|
Hmmm, it doesn't appear to be excluding for py2 based on the failures... |
Contributor
|
Oh, I see #597 now. Good deal. |
Contributor
Author
|
now pytest doesn't complain about not knowing the |
basepi
reviewed
Sep 25, 2019
beniwohli
force-pushed
the
chained-exceptions
branch
2 times, most recently
from
479abac to
9a1587c
Compare
Unfortunately, `--ignore-glob` doesn't seem to work properly on Windows
beniwohli
force-pushed
the
chained-exceptions
branch
from
9a1587c to
bc59bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an exception has a
__context__set, we use its traceback for thechained exception. The exception type and value are either taken from
__cause__(if set) or__context__.closes #526