use hardcoded logging names instead of __name__#212
Closed
beniwohli wants to merge 1 commit intoelastic:masterfrom
Closed
use hardcoded logging names instead of __name__#212beniwohli wants to merge 1 commit intoelastic:masterfrom
__name__#212beniwohli wants to merge 1 commit intoelastic:masterfrom
Conversation
`__name__` is only the module name, so in e.g. `elasticapm.intrumentation.packages.base`, the logger name would be `base`. By prefixing all logger names with `elasticapm`, it should be easier to filter/debug log messages from elasticapm itself. Additionally, this PR also contains tests for some of our logging.
beniwohli
force-pushed
the
internal-logging-enhancements
branch
from
eea1242 to
2f80dff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__name__is only the module name, so in e.g.elasticapm.intrumentation.packages.base, the logger name would bebase.By prefixing all logger names with
elasticapm, it should be easier tofilter/debug log messages from elasticapm itself.
Additionally, this PR also contains tests for some of our logging.