replace subclassing of wrapt wrappers by using a partial #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
remove-wrapt-subclasses
branch
5 times, most recently
from
dbe3675 to
2d9e80f
Compare
Contributor
Author
|
pypy tests fail because somehow this change introduces two additional frames into the captures span stack traces, but only on PyPy. No idea why... |
roncohen
approved these changes
Feb 21, 2018
beniwohli
force-pushed
the
remove-wrapt-subclasses
branch
from
2d9e80f to
46e59e6
Compare
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Feb 21, 2018
We need to pass along the method and module names to the function wrapper. This has so far been done by subclassing wrapt.FunctionWrapper. While this works, it adds a lot of duplicate code that we need to sync up every time we update wrapt. Using a partial should mean much less maintenance work. closes elastic#164
We need to pass along the method and module names to the function wrapper. This has so far been done by subclassing wrapt.FunctionWrapper. While this works, it adds a lot of duplicate code that we need to sync up every time we update wrapt. Using a partial should mean much less maintenance work. closes elastic#164
beniwohli
force-pushed
the
remove-wrapt-subclasses
branch
from
46e59e6 to
cf17525
Compare
beniwohli
added a commit
that referenced
this pull request
Feb 22, 2018
We need to pass along the method and module names to the function wrapper. This has so far been done by subclassing wrapt.FunctionWrapper. While this works, it adds a lot of duplicate code that we need to sync up every time we update wrapt. Using a partial should mean much less maintenance work. closes #164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass along the method and module names to the function
wrapper. This has so far been done by subclassing wrapt.FunctionWrapper.
While this works, it adds a lot of duplicate code that we need to sync
up every time we update wrapt. Using a partial should mean much less
maintenance work.