Emily lagattolla #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Ballenger
approved these changes
Jun 14, 2019
Collaborator
Nick-Ballenger
left a comment
Nick-Ballenger
left a comment
There was a problem hiding this comment.
This looks really good! The code is clear and concise, it shows that you have a good understanding of using classes, and you implemented it all really well!
Great job, you are going to rock this sprint so hard!
| } | ||
| } | ||
|
|
||
| class CharacterStats extends GameObjects { |
Collaborator
There was a problem hiding this comment.
Just to keep confusion down you can actually use the same naming convention across all the super/constructors if you want to (you could go with attrs/props across the board if you wanted to)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.