Updates - #21
Updates#21
Conversation
|
Thank you so much @Ansonator! However, I cannot merge it right now, since I'd have to review the code and update the tutorial to reflect these changes. I don't have the time right now and I think due to some changes on its platform, Pluralsight is not accepting changes to guides. Updating this project and the tutorial is something that's been on my to-do list for a long time, I have other priorities right now but is something I'm planning to do in the future. Thanks again! |
|
No problem. Odd that Pluralsight won't allow guide changes. That'll make
it difficult to ensure their quality and keep them up-to-date.
Whenever you have some time and take a look. Feel free to change it,
ignore it, request changes, etc.
Thanks for the tutorial.
…On Fri, Mar 26, 2021 at 9:03 PM Esteban Herrera ***@***.***> wrote:
Thank you so much @Ansonator <https://github.com/Ansonator>!
However, I cannot merge it right now, since I'd have to review the code
and update the tutorial to reflect these changes. I don't have the time
right now and I think due to some changes on its platform, Pluralsight is
not accepting changes to guides.
Updating this project and the tutorial is something that's been on my
to-do list for a long time, I have other priorities right now but is
something I'm planning to do in the future.
Thanks again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALUZ7JKNLD7JUNPT64MZK3TFU4FVANCNFSM4Z3PVPJA>
.
|
|
Thank you. About the guides, it's temporary, but I'd had to ask. In any case, I'll be busy for the next month or so, but after that, I'll look into this 👍 |
eh3rrera
left a comment
eh3rrera
left a comment
There was a problem hiding this comment.
Thank you so much @Ansonator for this pull request. I've reviewed and everything looks great, I just added two comments. Also, I don't know if you accidentally removed the mvnw and mvnw.cmd files or if there's a reason for this? Thanks.
|
Sorry, I looked at the diff and saw there were tons of lines showing up due to formatting changes. There's still some, but I fixed a lot of that. |
|
Merged, I give you credit on the README. Thank you so much! 👍 |
2 participants
Hi. I went through your tutorial on pluralsight. It's my first tutorial for GraphQL. Thanks!
I also went through some other materials and ended up changing this one to bring it more up-to-date and also to experiment with Lombok and JDK16.
pom.xmlchange when I tried using jdk16.I think the uplifts are useful. The rest is fluff. If you want me to remove any/all of the fluff before merging, let me know.
Thanks.