This repository was archived by the owner on Feb 20, 2019. It is now read-only.
feat(getTriangleType): get type of a Triangle#252
Merged
kentcdodds merged 1 commit intoeggheadio-github:masterfrom Feb 18, 2019
bolah2009:pr/getTriangleType
Merged
feat(getTriangleType): get type of a Triangle#252kentcdodds merged 1 commit intoeggheadio-github:masterfrom bolah2009:pr/getTriangleType
kentcdodds merged 1 commit intoeggheadio-github:masterfrom
bolah2009:pr/getTriangleType
Conversation
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 95 96 +1
Lines 465 466 +1
=====================================
+ Hits 465 466 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
Hi @kentcdodds, this is my first PR. After going through your Egghead.io series entitled: How to Contribute to an Open Source Project on GitHub am glad to push my first PR! Thanks! All checks have passed |
Member
|
Great job! |
Contributor
Author
|
Thanks for accepting the request!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function that gets the name of a triangle. The input is the three sides of the triangle and the output (return a
String) is the corresponding triangle name (Equilateral, Isosceles and Scalene).