Repository navigation
Conversation
Fixes effector#1186 VueEffector was incorrectly typed as a function that accepts a Plugin, but it is actually an object that implements the Plugin interface. This allows using it correctly with app.use(VueEffector) in Vue 3.
This was referenced Sep 6, 2026
Open
zerobias
pushed a commit
that referenced
this pull request
Sep 10, 2026
The type runner compiled every declaration file against Vue 2 typings, so
composition.d.ts and options-vue3.d.ts were never checked: they describe a
Vue 3 API and cannot share a program with the root entry point, which is
written against Vue 2. Nothing caught that options-vue3.d.ts was not even a
module, so `import {VueEffector} from 'effector-vue/options-vue3'` failed for
every Options API user on Vue 3.
The runner now makes a second compile() pass for src/types/__tests__/
effector-vue3 with vue mapped to the installed Vue 3 typings, and the reports
of both passes are merged into one file, so the snapshots keep working as
before. Existing tests keep the Vue 2 pass untouched.
The VueEffector declaration is taken from #1306 by kTelyakov. The effector
option is declared through ComponentCustomOptions, which is the first step
towards #598.
Fixes #1186
zerobias
added a commit
that referenced
this pull request
Sep 10, 2026
test(types): typecheck effector-vue Vue 3 typings, accept #1306
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1186
VueEffector was incorrectly typed as a function that accepts a Plugin, but it is actually an object that implements the Plugin interface.
This allows using it correctly with app.use(VueEffector) in Vue 3.
Conventions