Repository navigation
fix: vue3 break effector-vue - #1281
Open
movpushmov wants to merge 1 commit into
Open
movpushmov wants to merge 1 commit into
movpushmov wants to merge 1 commit into
Conversation
This was referenced Sep 6, 2026
Open
Merged
leo-millennial
added a commit
to leo-millennial/effector
that referenced
this pull request
Sep 10, 2026
The plugin is part of the composition API: it provides the scope that useUnit, useStoreMap, useVModel and useGate read. Exporting it only from the root entry forced Vue 3 users to import from the Vue 2 entry, which pulls in the mixin and createComponent they never run. The composition entry stays free of a default vue import, so it also works where the root entry is loaded by a bundler that resolves vue to the Vue 3 build. Adopts the change proposed in effector#1281 by movpushmov, with the typing added to composition.d.ts so the export is visible to TypeScript users too. Fixes effector#1131
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conventions