fix(fetch-hooks): extract binary data URLs from request.json to sidec… #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar files - Add createRequestFileKV() for requests that extracts/restores inline base64 data URLs (data:image/png;base64,...) to sidecar files like request.json.assets/0001.png - Add createTextFileKV() for response bodies with same binary extraction - Update createFilesystemStorage() to use new KV types for requests and response bodies - Update test helper findCachedResponse() to handle raw text format - Add tests verifying binary extraction/restoration for both requests and responses
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfd626c3ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR implements automatic extraction of inline base64 data URLs (e.g., data:image/png;base64,...) from cached request and response JSON files to separate sidecar binary files, improving cache readability and reducing file bloat.
Key Changes:
- Introduces
createRequestFileKV()andcreateTextFileKV()functions that automatically extract/restore data URLs to sidecar files (e.g.,request.json.assets/0001.png) - Updates
createFilesystemStorage()to use these new KV implementations for requests and response bodies - Updates
findCachedResponse()test helper to handle both new (raw text) and old (JSON-wrapped) response formats
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages-native/fetch-hooks/src/filesystem-storage.ts |
Adds createRequestFileKV() and createTextFileKV() functions that integrate binary extraction/restoration using the existing binary-extractor module, and updates createFilesystemStorage() to use these new storage implementations |
packages-native/fetch-hooks/test/cache-manager.test.ts |
Updates findCachedResponse() helper to handle raw text response format and adds comprehensive integration tests verifying binary extraction/restoration for both requests and responses |
- Simplify variable handling in createRequestFileKV.set() and createTextFileKV.set() - Add comprehensive JSDoc documentation for createRequestFileKV and createTextFileKV - Add test for response body restoration round-trip - Add changeset for binary sidecar extraction feature
Member
Author
Feedback addressed in 003794fCopilot suggestions (all addressed):
Codex/chatgpt-codex-connector suggestion (not addressed):
Also added:
|
subtleGradient
added a commit
that referenced
this pull request
Jan 8, 2026
#207) * fix(fetch-hooks): extract binary data URLs from request.json to sidecar files - Add createRequestFileKV() for requests that extracts/restores inline base64 data URLs (data:image/png;base64,...) to sidecar files like request.json.assets/0001.png - Add createTextFileKV() for response bodies with same binary extraction - Update createFilesystemStorage() to use new KV types for requests and response bodies - Update test helper findCachedResponse() to handle raw text format - Add tests verifying binary extraction/restoration for both requests and responses * refactor(fetch-hooks): address PR feedback - simplify code and add docs - Simplify variable handling in createRequestFileKV.set() and createTextFileKV.set() - Add comprehensive JSDoc documentation for createRequestFileKV and createTextFileKV - Add test for response body restoration round-trip - Add changeset for binary sidecar extraction feature
subtleGradient
added a commit
that referenced
this pull request
Jan 8, 2026
#207) * fix(fetch-hooks): extract binary data URLs from request.json to sidecar files - Add createRequestFileKV() for requests that extracts/restores inline base64 data URLs (data:image/png;base64,...) to sidecar files like request.json.assets/0001.png - Add createTextFileKV() for response bodies with same binary extraction - Update createFilesystemStorage() to use new KV types for requests and response bodies - Update test helper findCachedResponse() to handle raw text format - Add tests verifying binary extraction/restoration for both requests and responses * refactor(fetch-hooks): address PR feedback - simplify code and add docs - Simplify variable handling in createRequestFileKV.set() and createTextFileKV.set() - Add comprehensive JSDoc documentation for createRequestFileKV and createTextFileKV - Add test for response body restoration round-trip - Add changeset for binary sidecar extraction feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ar files
Add createRequestFileKV() for requests that extracts/restores inline base64 data URLs (data:image/png;base64,...) to sidecar files like request.json.assets/0001.png
Add createTextFileKV() for response bodies with same binary extraction
Update createFilesystemStorage() to use new KV types for requests and response bodies
Update test helper findCachedResponse() to handle raw text format
Add tests verifying binary extraction/restoration for both requests and responses