Add wish/wrapper control plane CLI package#160
Draft
subtleGradient wants to merge 1 commit intoeffect-native/mainfrom
Draft
Add wish/wrapper control plane CLI package#160subtleGradient wants to merge 1 commit intoeffect-native/mainfrom
subtleGradient wants to merge 1 commit intoeffect-native/mainfrom
Conversation
subtleGradient
commented
Nov 20, 2025
Member
Author
subtleGradient
left a comment
subtleGradient
left a comment
There was a problem hiding this comment.
Use @effect/platform instead of node:fs or node:path
Comment on lines
+16
to
+19
| Effect.tryPromise({ | ||
| try: () => fs.readFile(configPath, "utf8"), | ||
| catch: (error) => error as Error | ||
| }) |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+23
to
+27
| const configPath = path.join(rootDir, "wrp.config.json") | ||
| const exists = yield* Effect.tryPromise({ | ||
| try: () => fs.access(configPath).then(() => true).catch(() => false), | ||
| catch: (error) => error as Error | ||
| }) |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+33
to
+34
| const content = yield* readConfigFile(configPath) | ||
| const parsed = JSON.parse(content) as Partial<WrpConfig> |
Member
Author
There was a problem hiding this comment.
Use Effect Schema instead
Comment on lines
+11
to
+14
| Effect.tryPromise({ | ||
| try: () => fs.access(filePath).then(() => true).catch(() => false), | ||
| catch: (error) => error as Error | ||
| }) |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+16
to
+26
| const ensureDir = (dir: string) => | ||
| Effect.tryPromise({ | ||
| try: () => fs.mkdir(dir, { recursive: true }), | ||
| catch: (error) => error as Error | ||
| }) | ||
|
|
||
| const writeFile = (filePath: string, content: string) => | ||
| Effect.tryPromise({ | ||
| try: () => fs.writeFile(filePath, content, "utf8"), | ||
| catch: (error) => error as Error | ||
| }) |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+83
to
+84
| const promptgraphRoot = path.join(rootDir, config.promptgraphDir) | ||
| const targetsRoot = path.join(rootDir, config.targetsDir) |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+1
to
+2
| import { promises as fs } from "node:fs" | ||
| import path from "node:path" |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
| @@ -0,0 +1,15 @@ | |||
| import { spawn } from "node:child_process" | |||
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+1
to
+2
| import { promises as fs } from "node:fs" | ||
| import path from "node:path" |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
Comment on lines
+1
to
+2
| import { promises as fs } from "node:fs" | ||
| import path from "node:path" |
Member
Author
There was a problem hiding this comment.
Use @effect/platform instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task