Fix release workflow: remove version check and skip Chrome test in CI#157
Draft
Copilot wants to merge 3 commits intoeffect-native/mainfrom
Draft
Fix release workflow: remove version check and skip Chrome test in CI#157Copilot wants to merge 3 commits intoeffect-native/mainfrom
Copilot wants to merge 3 commits intoeffect-native/mainfrom
Conversation
Co-authored-by: subtleGradient <4117+subtleGradient@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue to unbreak the release
Fix CLI test: update expected version from 0.0.1 to 0.1.0
Oct 10, 2025
subtleGradient
requested changes
Oct 11, 2025
Member
subtleGradient
left a comment
subtleGradient
left a comment
There was a problem hiding this comment.
Remove the version check in the test entirely
Member
|
@copilot Be sure to also for the Error: Timed out waiting for Chrome debugger target (last-error=fetch failed) By skipping that test in CI since there's no chrome available in CI |
Co-authored-by: subtleGradient <4117+subtleGradient@users.noreply.github.com>
Contributor
Author
Fixed. Added
Done in commit 40ae7a0 and updated. Removed the version check from the CLI test entirely. |
Copilot
AI
changed the title
Fix CLI test: update expected version from 0.0.1 to 0.1.0
Fix release workflow: remove version check and skip Chrome test in CI
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow was failing due to two test failures:
CLI test version mismatch: The test was asserting a specific version string
0.0.1in the help output, but the package version had been bumped to0.1.0inpackage.json.Chrome debugger test timeout: The test
"connects to Chrome remote debugging"was failing in CI withError: Timed out waiting for Chrome debugger target (last-error=fetch failed)because Chrome is not available in the CI environment.Solution
Removed version check entirely from the CLI test to make it more maintainable. Version assertions are brittle and don't add meaningful value to the test - the test now focuses on verifying the actual help content is present.
Skip Chrome test in CI by adding
it.effect.skipIf(!!process.env.CI)to conditionally skip the Chrome remote debugging test when running in CI environments where Chrome is not available.Changes
packages-native/effect-native/test/cli.test.tspackages-native/debug/test/CdpConnection.test.tsfor the Chrome remote debugging testVerification
✅ CLI test passes successfully
✅ Chrome test is skipped in CI (but runs locally)
✅ Full test suite: 80 passed | 9 skipped
✅ All linting checks pass
This fix unblocks the release workflow by addressing both test failures that were preventing successful builds.
Fixes #156
Original prompt
Fixes #156
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.