feat: bootstrap bidi request routing #151
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bootstraps the foundation for WebDriver BiDi support in the effect-native fork by creating the @effect-native/bidi package with essential request/response routing infrastructure.
Key changes:
- Created the
@effect-native/bidipackage with full TypeScript and build configuration - Implemented core BiDi service with request/response correlation and event handling using Effect primitives
- Added comprehensive test coverage for command routing and error handling scenarios
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.specs/bidi/progress.md |
Documents WebDriver BiDi implementation milestones and current progress |
packages-native/bidi/package.json |
Package configuration with Effect peer dependencies and build scripts |
packages-native/bidi/src/BiDi.ts |
Public API exports for BiDi types and services |
packages-native/bidi/src/index.ts |
Main package entry point |
packages-native/bidi/src/internal/BiDi.ts |
Core BiDi service implementation with request routing and event handling |
packages-native/bidi/test/BiDi.test.ts |
Test suite covering command correlation and error scenarios |
packages-native/bidi/tsconfig.*.json |
TypeScript configuration files for build and test compilation |
packages-native/bidi/vitest.config.ts |
Vitest test configuration |
packages-native/bidi/README.md |
Package documentation with usage examples |
packages-native/bidi/LICENSE |
License reference file |
packages-native/bidi/CHANGELOG.md |
Package changelog initialization |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
@Codes unbreak the checks. looks like [21:20:54.641] ERROR (#12): |
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d6f9e082f8832f82a4ce3673d79f64