Merged
Conversation
Author
|
nevermind, I will make a PR against phpredis/phpredis instead... thanks |
Owner
|
Hi! Well done! Thank you! I have merged your changes to this repo. |
Author
|
@edtechd oh, great, thanks for the merging...... but...it is till underworking..(I even didn't test it). I tried to merge this to the phpredis/phpredis repo, but lots of conflicts... :< |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey:
This is a under working PR which try to make this extension works with PHP7.
Sorry for saying this, but I must say, the current implementation is really mess, and it must not works....
Anyway, I hope I can make this a little better, but I am afraid I don't have much time on this...
thanks