Skip to content

fix redis_globals, make shared at snaphot build #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edtechd merged 1 commit into from
Jul 4, 2015
Merged

fix redis_globals, make shared at snaphot build #1

edtechd merged 1 commit into from
Jul 4, 2015

Conversation

@Jan-E
Copy link

@Jan-E Jan-E commented Jul 4, 2015

@edtechd Fixed 2 things.Now I am getting only this error:

Creating library C:\php-sdk\php70dev\Release_TS\php_redis.lib and object C:\php-sdk\php70dev\Release_TS\php_redis.exp
library.obj : error LNK2001: unresolved external symbol _basic_globals_id
C:\php-sdk\php70dev\Release_TS\php_redis.dll : fatal error LNK1120: 1 unresolved externals
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\link.exe"' return code '0x460'

Must be something simple. I'll ask @rlerdorf

edtechd added a commit that referenced this pull request Jul 4, 2015
@edtechd
Merge pull request #1 from Jan-E/php7
5055603 
fix redis_globals, make shared at snaphot build
@edtechd edtechd merged commit 5055603 into edtechd:php7 Jul 4, 2015
@edtechd
Copy link
Owner

edtechd commented Jul 4, 2015

Thanks! I just forgot to commit this change to redis.c.
The error message is very similar to that I posted on the apachelounge forum, and it only appears when you try to compile it as a shared module. It should work well when compiling the extension statically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jan-E @edtechd